Migrate and refactor image block e2e tests to Playwright#40804
Merged
Conversation
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
kevin940726
commented
May 6, 2022
| } | ||
| } ); | ||
|
|
||
| test( 'should place caret at end of caption after merging empty paragraph', async ( { |
Member
Author
There was a problem hiding this comment.
This test was originally skipped (#32872), but I couldn't reproduce it after the migration. Let's enable it and see if it fixes the issue.
glendaviesnz
approved these changes
May 6, 2022
glendaviesnz
left a comment
Contributor
There was a problem hiding this comment.
LGTM - pulls in all the same tests as the existing image.test.js and completes locally on multiple runs, and in CI. 🤞 it will fix some of the ongoing flakey issues with the image tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate and refactor
image.test.jsto Playwright.Hopefully fixes #36904, fixes #35873, fixes #35506, fixes #35502, fixes #34832, fixes #32872.
Why?
See this post for an overview of the migration.
How?
By following the migration guide.
Testing Instructions