Revert "Allow negative values for margin inputs (#40464)"#40674
Merged
Revert "Allow negative values for margin inputs (#40464)"#40674
Conversation
This reverts commit a109d31.
|
Size Change: -39 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Apr 28, 2022
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for wrangling this @aristath
this PR reverts the commit so that we can have a bigger discussion and an actionable plan before committing to this.
While the revert is unfortunate, I believe reaching a consensus plan to address the issues negative margins introduce into the editor is a wise choice for the moment.
We'll also need to close #40653 if we proceed with this.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a109d31.
Following the comments in #40464 (comment), this PR reverts the commit so that we can have a bigger discussion and an actionable plan before committing to this.
cc @aaronrobertshaw @ndiego @JustinyAhin