Try to fix flaky playwright tests not being reported#40290
Merged
Conversation
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
talldan
approved these changes
Apr 13, 2022
talldan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Let's give it a go and see whether it works.
Member
Author
|
Test failures seem unrelated and are also happening on trunk. |
Contributor
|
The failing test is caused by a WordPress core issue and fixed by this PR - WordPress/wordpress-develop#2580. So this is safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Try to fix flaky playwright tests not being reported.
Why?
To allow flaky playwright tests to be reported to issues so that we can keep track of them.
How?
Honestly, this PR is just a guess. There's a warning in the
upload-artifactaction doc:This PR tries to address that by choosing a different name for each job and use
artifactNamePrefixinsteadofartifactName`.Testing Instructions
Unfortunately, don't have a reliable way to test it for now.