Show topbar when chrome exists#40094
Closed
draganescu wants to merge 8 commits intotry/hide-block-toolbar-before-selectionfrom
Closed
Show topbar when chrome exists#40094draganescu wants to merge 8 commits intotry/hide-block-toolbar-before-selectionfrom
draganescu wants to merge 8 commits intotry/hide-block-toolbar-before-selectionfrom
Conversation
- site icon and W menu slide from left - toolbar items slide from top
|
Size Change: -129 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Contributor
Author
|
The X slide respects the animate directive in the top most element but for whatever reason the Y slides don't. |
Contributor
|
Thanks again for putting this together @draganescu, it's good to have in the back pocket as we continue to explore this feature. I'd love to hear thoughts from others, but for me this is a good example of why we might need some defining principles for this mode in order for it to be successful. While this change makes sense on the surface, I personally find the 'distraction free' concept entirely shattered by simply opening the block Inspector, which probably isn't where we want to be? |
fcf2cbd to
f173674
Compare
Contributor
Author
|
I've added this to the original (#38928). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to solve #38928 's problem with sidebars cc @jameskoster
Exploration around distraction free mode depending on Gutenberg chrome:
auto-exit-reduced.mp4