Revert "Global styles: remove block gap control"#39845
Conversation
This reverts commit dcad2b4.
|
Size Change: +105 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Do you know why the root gap support regressed? Seems like it's important to fix that (to avoid WP 6.0 regression) |
…ey do not work on the frontend. We do this by checking for a block name and then returning false.
We only noticed it recently, but think it was after this PR was merged: Specifically, this line: 'spacing' => array(
....
'blockGap' => 'top', // <- this will be skipped when adding to `$schema['styles']['blocks']`
),There's a comment in The current thinking is that we do something in layout to get around this. Documented in: |
|
I think maybe we should merge this one for now, just in case we run into any blockers in the follow up: |
apeatling
left a comment
There was a problem hiding this comment.
✅ No block gap UI in global styles for any block, or layout
✅ Block gap appears at the individual block settings level when supported
Reverts #39601
Was meant to be temporary, but probably a hammer where we need a scalpel.
For now we're checking for a block name, e.g.,
core/groupand returning false fromuseGapin order to hide the block gap controls for block-level global styles.Looking at block-level gap support over in: