Conversation
By doing this, we are also deregistering it for the deprecations.
oandregal
commented
Mar 29, 2022
| * @param {string} blockName The name of the block to be registered. | ||
| * @return {Array} New settings. | ||
| */ | ||
| function registerQuoteV2Attributes( blockSettings, blockName ) { |
Member
Author
There was a problem hiding this comment.
Had to remove the filter because it was affecting the deprecation, preventing it from having the value attribute to migrate. The result of this change is that when v2 is enabled, the value attribute will still be present.
We need to remove the attribute from the block.json when v2 becomes the default (see).
Contributor
There was a problem hiding this comment.
We need to remove the attribute from the block.json when v2 becomes the default
I don't think we can remove it until the useMigrateOnLoad is removed.
oandregal
commented
Mar 29, 2022
| } ) { | ||
| const { citation } = attributes; | ||
|
|
||
| useMigrateOnLoad( attributes, clientId ); |
Member
Author
There was a problem hiding this comment.
This is using the same technique than the list v2 uses https://github.com/WordPress/gutenberg/pull/39799/files#diff-8ca208404bc35d0549ee68bfdb5c87a0d1fa101ddcfad1095d9a3c0e171b0272
|
Size Change: -55 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 29, 2022
youknowriad
reviewed
Mar 29, 2022
youknowriad
reviewed
Mar 29, 2022
Member
Author
|
@youknowriad @ellatrix is there anything else to do here? |
youknowriad
requested changes
Mar 29, 2022
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
I've noticed that any format (bold) in paragraphs is removed after conversion.
Member
Author
The same happens when transforming from pullquote to quote. |
oandregal
commented
Mar 29, 2022
| query: { | ||
| content: { | ||
| type: 'string', | ||
| source: 'text', |
Member
Author
There was a problem hiding this comment.
I've commited this here because it's the same fix I did for the migration. Thought it doesn't deserve a separate PR.
Co-authored-by: Riad Benguella <benguella@gmail.com>
Member
Author
|
@youknowriad the formats are now working. I've also pushed the same fix for the Pullquote to Quote transform in this PR (f3cac07). |
youknowriad
approved these changes
Mar 29, 2022
youknowriad
reviewed
Mar 29, 2022
Co-authored-by: Riad Benguella <benguella@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15486
Related #25892
What?
This PR adds the migration from quote v1 to quote v2.
Why?
We need to support existing content.
How?
Testing Instructions
Verify that the deprecation works:
to-quote-v2.mp4
Verify that templates provided to CPT are migrated:
gutenberg.php:template-quote.mp4