Merged
Conversation
Member
Author
|
In rebasing I found that there was an issue with the changing effect dispatch order causing a new post to be marked as dirty, since while we reset change detection the |
youknowriad
approved these changes
Jan 17, 2018
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
This needs a rebase but let's get it in
Member
|
@aduth can you rebase and merge? :) |
refx 3.x effets are fired _after_ the original dispatch finishes
The RESET_POST action type is used as a reset type for change detection, but must occur as the last effect of editor initialization to avoid the new-post-setup title changes from marking the post as having changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to bump the
refxdependency from2.1.0to3.0.0.View Changelog
3.0.0 introduces changed call order of the effect, occurring after an action has been applied to state rather than before. This avoids the need for a
setTimeoutartificial delay ineffects.js.It could also enable refactoring the jQuery meta box
holdReadybehavior, as described at #3476 (review).Testing instructions:
Verify there are no regressions in the behavior of side-effects, notably save behaviors.