[create-block] Add npmDevDependencies as a template variable.#39723
Merged
gziolo merged 7 commits intoWordPress:trunkfrom Mar 25, 2022
Merged
Conversation
…ow what packages are being installed.
gziolo
approved these changes
Mar 25, 2022
Contributor
Author
|
Thanks, @gziolo! Not sure about the CI either, I tried pushing another commit to restart the jobs but that did nothing. |
875e7ae to
99f86ed
Compare
dgwyer
approved these changes
Mar 25, 2022
Contributor
dgwyer
left a comment
There was a problem hiding this comment.
Just updated a couple of typos.
Co-authored-by: David Gwyer <dgwyer@users.noreply.github.com>
Contributor
Author
|
For posterity, I was able to get the CI job to re-run by rebasing from |
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a new template variable to the create-block package to allow templates to define
devDependencies.Closes #39722
Why?
Some blocks require
devDependencesthat should not be added to regulardependencies.How?
This is done by introducing a
npmDevDependenciesvariableTesting Instructions
npmDevDependenciesentry to the index.js and add an array of dependenciesRun ./node_modules/.bin/wp-create-block --template={pathTo}/dynamic-block-template