Fix Nav block error on toggle of Advanced inspector control panel#39676
Closed
Fix Nav block error on toggle of Advanced inspector control panel#39676
Advanced inspector control panel#39676Conversation
Former method appears to have been deprecated.
Contributor
That doesn't seem good, must have been a breaking change? |
|
Size Change: -1 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Contributor
Author
Can you find it anymore? I searched the codebase and couldn't see a reference which seems very odd. Surely we'd have a deprecation notice? |
Contributor
|
Looks like it was #39349 where the function was renamed. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a bug whereby the Nav block would crash if the user toggled the
Advancedpanel in the block inspector controls.Why?
The block crashes if we don't fix this.
How?
The block relied on a selector from
@wordpress/core-datacalleduseEntityIdwhich no longer exists 🤷♂️This PR updates to use an alternative selector
useEntityPropto fetch theidinstead.Testing Instructions
Advancedpaneltrunkwhere it does crashScreenshots or screencast