Accessibility improvements to the query pagination block#39536
Merged
Conversation
e1b6c8d to
2d4203c
Compare
Contributor
Screen readers tend to announce the element role by default, and here |
Member
Author
Thanks for pointing that out @chthonic-ds. I have just renamed the |
Member
|
Should this also be changed in the |
Member
Author
I think that would make sense @aristath. I've applied that change, and it seems to be working. Although I don't know if this has other implications. |
|
Size Change: +4.32 kB (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Mar 22, 2022
aristath
left a comment
Member
There was a problem hiding this comment.
LGTM! 👍 Small, but meaningful improvement.
Once tests pass I think this can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39535.
What?
This PR adds some accessibility improvements to the query pagination block.
Why?
See https://www.a11ymatters.com/pattern/pagination/
How?
<div>wrapper and adds the block attributes to a<nav>elementaria-label"Pagination" to thenavTesting Instructions
navelement with thearia-label"Pagination Navigation"navelement should contain the block classes previously in thedivwrapperScreenshots or screencast
Before
After