Skip to content

Add new option to show or hide empty categories#39426

Merged
amustaque97 merged 4 commits intoWordPress:trunkfrom
mauriac:update/categories-block
Apr 14, 2022
Merged

Add new option to show or hide empty categories#39426
amustaque97 merged 4 commits intoWordPress:trunkfrom
mauriac:update/categories-block

Conversation

@mauriac
Copy link
Copy Markdown
Member

@mauriac mauriac commented Mar 14, 2022

What?

New option to show or hide empty categories (non-breaking change which adds functionality)

Why?

Fixes #35489

How?

Testing Instructions

Screenshots or screencast

Screenshot at Mar 14 15-49-07

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 14, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mauriac! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Categories Affects the Categories Block label Mar 24, 2022
amustaque97
amustaque97 reviewed Apr 10, 2022
View reviewed changes
@mauriac
Fix inverted behaviour
fb8acb5 
When "Show empty categories" is checked empty categories do not show
and vice versa. This post fix that behavious.
@mauriac mauriac requested a review from juanmaguitar as a code owner April 14, 2022 00:12
@ntsekouras ntsekouras added [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement. labels Apr 14, 2022
ntsekouras
ntsekouras reviewed Apr 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mauriac! Besides the indentation change this looks good!

@amustaque97
Copy link
Copy Markdown
Member

amustaque97 commented Apr 14, 2022

Thank you once again @mauriac for working on this. Let's wait for the pipeline to finish and if there are no errors. Will merge it.

@amustaque97 amustaque97 merged commit 45981a6 into WordPress:trunk Apr 14, 2022
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 14, 2022
@mauriac
Copy link
Copy Markdown
Member Author

mauriac commented Apr 14, 2022

@amustaque97 thanks for handling this... Please what is Gutenberg policy about branch deleting? Should I leave the branch for history or delete it to maintain the repository clean?
Thank you again.

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Apr 14, 2022

@mauriac, feel free to delete the branch 👍

@mauriac mauriac deleted the update/categories-block branch April 14, 2022 13:12
@bph bph added the Needs User Documentation Needs new user documentation label Jul 26, 2022
@femkreations femkreations mentioned this pull request Sep 24, 2022
Closed
11 tasks
@skorasaurus skorasaurus mentioned this pull request Oct 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amustaque97 amustaque97 amustaque97 left review comments

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ockham ockham Awaiting requested review from ockham

Assignees

No one assigned

Labels

[Block] Categories Affects the Categories Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs User Documentation Needs new user documentation [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 13.1

Development

Successfully merging this pull request may close these issues.

No "hide_empty" setting on Categories block

6 participants

@mauriac @amustaque97 @Mamaduka @ntsekouras @bph @skorasaurus