Theme Export: Add index.php and style.css#39173
Merged
Conversation
|
Size Change: -30 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
10 tasks
Mamaduka
reviewed
Mar 3, 2022
Comment on lines
+70
to
+73
| $zip->addFromString( | ||
| 'theme/style.css', | ||
| file_get_contents( get_stylesheet_directory() . '/style.css' ) | ||
| ); |
Member
There was a problem hiding this comment.
I think we can use ZipArchive::addFile here. It is what core uses in privacy tools export.
draganescu
reviewed
Mar 3, 2022
|
|
||
| $zip->addFromString( | ||
| 'theme/index.php', | ||
| '<?php // This file is needed to make the theme work, but it doesn\'t do anything.' |
Contributor
There was a problem hiding this comment.
Can we go with "Silence is golden"?
Contributor
Author
There was a problem hiding this comment.
I wonder if the best thing to do is the same as for the style.css - just copy the index.php
draganescu
approved these changes
Mar 3, 2022
Contributor
draganescu
left a comment
There was a problem hiding this comment.
I am approving this as it is easy to update and revert but it gives us a ground to see how it works. After checking out the nit picks, 🚢
Contributor
Author
|
I changed the approach slightly to just copy the index.php and style.css from the current theme. |
Mamaduka
approved these changes
Mar 3, 2022
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks, @scruffian!
We also might want to use wp_normalize_path for file paths.
8 tasks
36 tasks
37 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an index.php and style.css to the export part of the Site Editor. Addressing part of #38199. This raises a few questions:
Testing Instructions
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).