Merged
Conversation
jorgefilipecosta
approved these changes
Dec 12, 2017
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Changes look good to me 👍 .
I tested the code and I did not found any regression. Regarding the console errors in transforms I was able to reproduce them in master and here they are fixed. For the errors in the heading, I did not manage to reproduce them in master. I think a parallel change may have changed the behavior but according to the discussion, the related change done here makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3867
Description
onKeyDownevent propagating when splitting content, as @ephox-mogran noticed.How Has This Been Tested?
Attachment 1: Example HTML paragraph
Screenshots (jpeg or gifs if applicable):
Types of changes
Checklist: