Avoid duplicate labels for "Save Draft" and "Save as pending" buttons#38776
Merged
Conversation
Mamaduka
commented
Feb 14, 2022
| variant={ isLargeViewport ? 'tertiary' : undefined } | ||
| icon={ isLargeViewport ? undefined : cloudUpload } | ||
| label={ label } | ||
| label={ showIconLabels ? undefined : label } |
Member
Author
There was a problem hiding this comment.
I'm not 100% sure that we need a label here. The button text should be enough from a11y perspective; this only serves as a visual enhancement for the tooltip.
Contributor
There was a problem hiding this comment.
I think the aria-label was there because that button used to be just an icon on all breakpoints. As long as there's text in the button, the aria-label isn't needed.
Member
Author
There was a problem hiding this comment.
Do you recommend removing label or reverting changes from #38790?
Contributor
There was a problem hiding this comment.
No, I think it's fine as it is; we still need to render the label when showing the icon button on mobile.
jasmussen
approved these changes
Feb 14, 2022
jasmussen
left a comment
Contributor
There was a problem hiding this comment.
Nice one. Before:
After:
A single label for screenreaders is definitely desired, no reason to read the same thing twice.
|
Size Change: +3 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
Member
Author
I think that is still the case. Screen readers will read hidden labels + text. Should we remove the label prop? |
Contributor
My take was that this would only output a single piece of text (label was perhaps imprecise). If @tellthemachines has any insights to add, I'd call her the authority on this. |
tellthemachines
approved these changes
Feb 15, 2022
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this @Mamaduka !
| variant={ isLargeViewport ? 'tertiary' : undefined } | ||
| icon={ isLargeViewport ? undefined : cloudUpload } | ||
| label={ label } | ||
| label={ showIconLabels ? undefined : label } |
Contributor
There was a problem hiding this comment.
I think the aria-label was there because that button used to be just an icon on all breakpoints. As long as there's text in the button, the aria-label isn't needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the issue when duplicated labels are displayed for the
PostSavedStatebutton.Resolves #38773.
Testing Instructions
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).