feat: add spell check icon#38691
feat: add spell check icon#38691bestony wants to merge 1 commit intoWordPress:trunkfrom bestony:bestony/add-spellcheck-icon
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bestony! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Hey, thanks so much for the PR! I'd like for the contribution flow for icons to become solidified and clearer. It's been a task for a while but has taken a backseat to other priorities. At the moment, the flow is unclear, and spread in comments across the github archive, obtuse for any new contributors to find. Sorry about that. Part of that flow means proposing the new icon in the WordPress.org slack in the #design channel, so we can ensure a consistent appearance across the set. Another rule of thumb is when we add a new icon vs. not, which is somewhere on the spectrum between a component in the core project needs it and it's a highly useful icon likely to be used by many plugins. In this case, I could see a spell check icon being useful for plugins, abolutely! But I think we need to go through the design submission process first, especially as Dashicons are not being developed anymore. In the mean time, if you urgently need to use this spell-check icon in your project, you can use the SVG directly using the Icon component, like so: That way you can use your custom SVG as any other icon in the set today. Thanks again for the PR, and hopefully I can return soon with a singular place for the icon contribution flow! 🚀 |
|
LGTM, i will close this PR @jasmussen |
Description
add a spell check icon for
@WordPress/iconsScreenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).