Skip to content

feat: add spell check icon#38691

Closed
bestony wants to merge 1 commit intoWordPress:trunkfrom
bestony:bestony/add-spellcheck-icon
Closed

feat: add spell check icon#38691
bestony wants to merge 1 commit intoWordPress:trunkfrom
bestony:bestony/add-spellcheck-icon

Conversation

@bestony
Copy link
Copy Markdown

@bestony bestony commented Feb 10, 2022

Description

add a spell check icon for @WordPress/icons

source from dashicons

Screenshots

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 10, 2022
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @bestony! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added the [Package] Icons /packages/icons label Feb 10, 2022
@Mamaduka Mamaduka requested a review from jasmussen February 10, 2022 05:52
@jasmussen
Copy link
Copy Markdown
Contributor

Hey, thanks so much for the PR!

I'd like for the contribution flow for icons to become solidified and clearer. It's been a task for a while but has taken a backseat to other priorities. At the moment, the flow is unclear, and spread in comments across the github archive, obtuse for any new contributors to find. Sorry about that.

Part of that flow means proposing the new icon in the WordPress.org slack in the #design channel, so we can ensure a consistent appearance across the set. Another rule of thumb is when we add a new icon vs. not, which is somewhere on the spectrum between a component in the core project needs it and it's a highly useful icon likely to be used by many plugins.

In this case, I could see a spell check icon being useful for plugins, abolutely! But I think we need to go through the design submission process first, especially as Dashicons are not being developed anymore.

In the mean time, if you urgently need to use this spell-check icon in your project, you can use the SVG directly using the Icon component, like so:

import { Icon } from '@wordpress/components';

const MyIcon = () => (
	<Icon
		icon={
			<svg>
				<path d="M5 4v3h5.5v12h3V7H19V4z" />
			</svg>
		}
	/>
);

That way you can use your custom SVG as any other icon in the set today.

Thanks again for the PR, and hopefully I can return soon with a singular place for the icon contribution flow! 🚀

@bestony
Copy link
Copy Markdown
Author

bestony commented Feb 10, 2022

LGTM, i will close this PR @jasmussen

@bestony bestony closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Icons /packages/icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants