Introduce the customScripts property to allow templates to define additional scripts in package.json#38535
Merged
ryanwelcher merged 3 commits intoWordPress:trunkfrom Feb 7, 2022
Conversation
Contributor
|
Hi |
gziolo
approved these changes
Feb 7, 2022
Member
There was a problem hiding this comment.
@ryanwelcher, this is a great idea 👍🏻
I considered it earlier when working on support for wpScripts or wpEnv, but at times it felt like too much work for every template to define all default scripts. However, this is nice, because it allows to inject or override scripts. I think you can also remove some scripts by providing a falsy value for a key.
customScripts property to allow templates to define additional scripts in package.json
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As referenced in #25188 (comment), this PR adds a
customScriptsproperty to templates to add additional custom scripts to the package.json. One use-case would be to add e2e tests ie."test:e2e": "wp-scripts test-e2e".Testing Instructions
./node_modules/.bin/wp-create-blockto ensure nothing is addedcustomScriptsentry to theindex.js./node_modules/.bin/wp-create-block --template={pathTo}/dynamic-block-templateTypes of changes
New Feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).