Size Change: +475 B (0%)

Total Size: 1.14 MB

_{compressed-size-action}

Can we add an e2e test for it maybe?

Sounds good to me.

Also should we implement in the site editor too?

I will add handlers to both Site and Widget editors. I just wanted to share the current implementation for feedback.

Do you think we should add the "Copy error" action to the notice?

I checked other error boundaries, and we have mixed UIs. For example, block boundary doesn't include actions, while general editor one does.

@Mamaduka I think I'd prefer without it personally as in general the copied error is minified... and doesn't add much value. I didn't hear much feedback about that button in the general editor boundary so would love to be proven wrong :)

I agree minified error message and trace isn't practical. At least in my experience when they are included in issues.

We can always include that later if there's a need for it.

Thanks again for the feedback, @youknowriad.

I think the code is ready for final review.

After the checks are complete, I will push documentation updates to ensure e2e tests aren't flaky. They work locally, but you never know.

I think I'd prefer without it personally as in general the copied error is minified... and doesn't add much value. I didn't hear much feedback about that button in the general editor boundary so would love to be proven wrong :)

Some discussion here on the general editor boundary, btw - #34482

I'm not sure I agree that the error messages aren't useful. They can sometimes provide information on where the error is even when minified. Or at least let the developer know which kind of error is happening.

Thanks for mentioning the general issue, @talldan. I just subscribed and am happy to help with development as well.

I'm not sure I agree that the error messages aren't useful. They can sometimes provide information on where the error is even when minified. Or at least let the developer know which kind of error is happening.

I don't have a strong opinion on this, and we can always add the "Copy" action later.

Let's merge this. Happy to follow up with the "Copy" action button if/when we see a need for it.

@bph, I'm not sure if this needs Dev Note. Yes, it improves developer experience but also requires zero actions from them :)

Anyway, happy to write a few words if we want to mention the improvement.

@Mamaduka I wasn't quite sure, but from what I learned listening to developer trying to work with blocks sometimes the error messages are not helpful, or don't point to the right places to start debugging. So anytime you improve things, it's a small win to be celebrated. It might not warrant an individual post but we will have a "Miscellaneous' DevNote where we gather a few smaller changes. :-)
It's entirely possible, that I don't understand the nature of this PR, so s short write up at least would educate me 🤣

I think it's worth mentioning in Misc.

P.S. Error boundary won't point folks in the right direction. It just prevents one error from crashing the whole editor.