Suggest picking a category on the pre-publish panel#37703
Merged
youknowriad merged 2 commits intotrunkfrom Jan 7, 2022
Merged
Conversation
|
Size Change: +214 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jan 4, 2022
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Uses can change default post category from Settings > Writing. Do we want to handle this scenario as well?
packages/editor/src/components/post-publish-panel/maybe-category-panel.js
Outdated
Show resolved
Hide resolved
Contributor
Author
How do you think this would impact the behavior here? |
Member
|
I think that depends on how we look at this feature. A. If we want to suggest assigning another category than "default," we need to take user-defined settings into account. |
Contributor
Author
|
It seems B is a better option to me, A default category (other than uncategorized) is probably always going to be a "good" category to pick from. |
Member
|
We can also keep it as it is and improve when we need it. |
Contributor
|
My understanding is that this PR will help folks pick a category other than Uncategorized but, if there's not another category, the only option once more is Uncategorized which defeats the purpose a bit IMO: |
Contributor
|
Nice! Would be cool if we also added a bit of educational text similar to tags. Maybe something like:
|
Contributor
Author
I thought about this but I decided to still keep the panel because they can add a category inline there.
👍 |
Contributor
|
This is neat, I often forget to assign categories :) Do we definitely need the logic though... or would it be adequate to simply repeat the panels from the document inspector 1:1? I ask because by comparison, I'm not sure that the "Suggestion: " text stands out enough to warrant the special treatment, and as mentioned above can feel a bit awkward in some circumstances. For example I don't use tags at all on my blog, and would find the constant "suggestion" a little aggravating, like my site doesn't know me :D Since the pre-publish panel is about double-checking settings, I don't know if we really need to frame these as "suggestions". |
Contributor
Author
|
I've added the educational text. If folks agree to remove "Suggestion:" from both tags and categories, I can do so 🤷♂️ |
Mamaduka
approved these changes
Jan 6, 2022
Member
Mamaduka
left a comment
There was a problem hiding this comment.
It looks good from a code perspective and as a feature.
I'm going to leave text copy decisions to others :)
d8dda30 to
ac72e7d
Compare
Contributor
|
I think for the purpose and context of tis PR, let's keep 'suggestion'. It's straight forward in what it is and inline with tags. For folks like Jay, who don't utilize tags or cats, they can ignore the said suggestions - no harm, no foul.
|
24 tasks
This was referenced Jun 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before publishing a post, if it has no assigned category or has the "uncategorized" one, this PR shows a new suggestion on the panel to pick a category before publishing.