Inserter: Remove duplicated and simplify sibling inserter styles#3705
Merged
Inserter: Remove duplicated and simplify sibling inserter styles#3705
Conversation
noisysocks
approved these changes
Nov 29, 2017
Member
noisysocks
left a comment
There was a problem hiding this comment.
👍 Code looks good and the inserter looks and behaves well.
57dbfd5 to
5cfbff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #3546
This pull request seeks to eliminate duplicated styles which were left-over in
VisualEditorstyles afterBlockListwas extracted to a separate component in #3546. Further, it simplifies width styling of the sibling inserter to not assume visual editor width, but instead apply padded centering via margins. This eliminates the implicit dependency between block list and visual editor, and is more accommodating to other inserter contexts (nesting).Testing instructions:
Verify that there are no visual regressions in the display of the block list inserter, for inserting between blocks, and when using the global and end-of-content inserters.