ToolsPanel: Prevent tools panel menu increasing empty panel height#36895
Merged
aaronrobertshaw merged 2 commits intotrunkfrom Dec 1, 2021
Merged
ToolsPanel: Prevent tools panel menu increasing empty panel height#36895aaronrobertshaw merged 2 commits intotrunkfrom
aaronrobertshaw merged 2 commits intotrunkfrom
Conversation
7 tasks
ciampo
approved these changes
Nov 26, 2021
Contributor
ciampo
left a comment
There was a problem hiding this comment.
Thank you @aaronrobertshaw ! Could you add a little CHANGELOG entry before merging?
Otherwise LGTM 🚀
d5dfe25 to
3b7be31
Compare
3b7be31 to
d3e8f87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks the
ToolsPanelso that an empty panel's height is consistent with a collapsed panel.This issue was raised through the review process of switch the border panel over to use the
ToolsPanel.See: #33743 (comment)
How has this been tested?
49pxnpm run storybook:devScreenshots
Types of changes
Enhancement.
Checklist:
*.native.jsfiles for terms that need renaming or removal).