[WIP] Layout block support: Try replacing uniqid class name with descriptive class names#36847
Closed
andrewserong wants to merge 1 commit intotrunkfrom
Closed
Conversation
5 tasks
Contributor
Author
|
I'm just closing out this draft PR exploration, as we'll revisit how we construct class names as part of server rendering in the style engine (tracked in #38167). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🚧 🚧 🚧 🚧 🚧
This is a WIP PR exploring an idea for swapping out the randomly generated
.wp-container-xxxxclass names used by the Layout block support with descriptive classnames that we can then use to programmatically regenerate CSS in the editor from rendered markup. The goal is to find a way to resolve #35376 and this exploration follows the approach suggested (as an exploration) in this comment.To-dos 🔨
WIP Screenshots
Step 1: render descriptive class names:
How has this been tested?
TBC
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).