Modal: add __experimentalHideHeader prop, wrap in forwardref#36831
Merged
Modal: add __experimentalHideHeader prop, wrap in forwardref#36831
Modal: add __experimentalHideHeader prop, wrap in forwardref#36831Conversation
|
Size Change: +29 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
14 tasks
| contentLabel, | ||
| onKeyDown, | ||
| isFullScreen = false, | ||
| __experimentalHideHeader = false, |
Member
There was a problem hiding this comment.
Oh, interesting! I'll keep this convention in mind for future additions.
fullofcaffeine
approved these changes
Nov 25, 2021
Member
fullofcaffeine
left a comment
There was a problem hiding this comment.
Code looks good, storybook stories too, and all tests are passing. I think this is good to go!
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Contributor
Author
|
Thank you @fullofcaffeine and @tyxla for the quick reviews 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a few changes to the
Modalcomponent that are required by #34153__experimentalHideHeaderprop, which hides the header part of the modal (title, icon, close button) and adjust styles accordinglyforwardRef, to allow external component to get a ref of the Modal's container//@ts-nocheckcomment at the start of each file (these comments will be removed when the component gets refactored to TypeScript)(Reviewing commit-by-commit should be an easier task)
How has this been tested?
ModalStorybook example has been updated to showcase the__experimentalHideHeaderprop in the "knobs" tabScreenshots
modal-hide-header.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).