Merged
Conversation
…control labels are uniform Organize imports alphabetically Remove hyphen from label
7 tasks
|
Size Change: +7.4 kB (+1%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
ramonjd
commented
Nov 10, 2021
packages/block-editor/src/components/letter-spacing-control/style.scss
Outdated
Show resolved
Hide resolved
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
The copy change LGTM 👍
I left one small comment regarding an unneeded class name. Once that is removed this should be good to go.
packages/block-editor/src/components/letter-spacing-control/index.js
Outdated
Show resolved
Hide resolved
aaronrobertshaw
approved these changes
Nov 15, 2021
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
After the classname removal, this is ready to ship 
✅ Copy looks good
✅ Reordered stylesheets are still imported correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Overwrites default component view label styles, forcing an 8px bottom margin on the letter spacing typography control so that the Typography control labels are uniformToolsPanel: Standardize input control label margin #36387 will take care of this.Testing
Insert a core text block – the paragraph block is an excellent choice. Select your block.
In the Typography Tools Panel in the right-hand sidebar, add a Letter spacing control.
The label margins should match and the label, for the Tools Panel options drop down and for the control itself should read
'Letter spacing', without the hyphen.Types of changes
Copy
Checklist:
*.native.jsfiles for terms that need renaming or removal).