Skip to content

Latest Posts: Add aria-label to featured links#36251

Merged
Mamaduka merged 4 commits intoWordPress:trunkfrom
silicondales:trunk
Dec 24, 2021
Merged

Latest Posts: Add aria-label to featured links#36251
Mamaduka merged 4 commits intoWordPress:trunkfrom
silicondales:trunk

Conversation

@robin-scott
Copy link
Copy Markdown
Contributor

@robin-scott robin-scott commented Nov 5, 2021

Fixes #36250

  • Move title var to top of foreach loop
  • include title as aria-label content for each featured image link

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Fixes - WordPress#36250

- Move title var to top of foreach loop
- include title as aria-label content for each featured image link
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 5, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @robin-scott! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

readability from auto test fail
spaces
@skorasaurus skorasaurus added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Latest Posts Affects the Latest Posts Block labels Dec 15, 2021
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @robin-scott. The changes look good to me.

@Mamaduka Mamaduka changed the title Add aria-label to featured links Latest Posts: Add aria-label to featured links Dec 24, 2021
@Mamaduka Mamaduka merged commit 6c15f2f into WordPress:trunk Dec 24, 2021
@github-actions
Copy link
Copy Markdown

Congratulations on your first merged pull request, @robin-scott! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 12.3 milestone Dec 24, 2021
@robin-scott
Copy link
Copy Markdown
Contributor Author

Connected. Thanks for approving, happy holidays 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Latest Posts Affects the Latest Posts Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility Fix for Featured Images as Links in Latest Posts Block

3 participants