Post Template. Return No results found in PHP to match JS.#36225
Closed
iandunn wants to merge 1 commit intoWordPress:trunkfrom
Closed
Post Template. Return No results found in PHP to match JS.#36225iandunn wants to merge 1 commit intoWordPress:trunkfrom
No results found in PHP to match JS.#36225iandunn wants to merge 1 commit intoWordPress:trunkfrom
Conversation
b9ae62a to
7e9a24a
Compare
Contributor
|
The pull request works as described, it adds the No results found. text to the front. This works well for search result pages, but it needs to be optional because it does not work well in other scenarios:
Related: #32606 |
This was referenced Jan 4, 2022
8 tasks
8 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36224
How has this been tested?
Ran the reproduction steps in #36224 before and after the change.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).