Merged
Conversation
This was referenced Nov 2, 2021
aaronrobertshaw
approved these changes
Nov 3, 2021
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Nice! 👌
I'm really glad to see we are moving in this direction regarding the migration of theme.json schemas.
✅ The code refactoring looks great
✅ Tests are all passing
✅ Manual testing of old theme.json schemas worked
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #34349
This PR prepares the code that migrates
theme.jsonschemas to add v2 in a subsequent PR, see #36155It clarifies how migrations are supposed to work and it proposes that each migration only updates from the latest to the new one. Before this, new migrations were supposed to be ported to all versions. See #34485 for an example. As demonstrated by the block deprecations #35663 trying to migrate everything to the latest version is not going to scale well.
How to test
Verify the tests pass. It only refactors code.