Merged
Conversation
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
add236c to
fb6d3a7
Compare
This was referenced Oct 28, 2021
fb6d3a7 to
0b75a95
Compare
0b75a95 to
2a6e093
Compare
Member
Author
|
CI is now green so this should be good to go. |
youknowriad
reviewed
Nov 24, 2021
packages/e2e-test-utils/package.json
Outdated
Contributor
There was a problem hiding this comment.
Is this the default behavior in npm7 or are we trying to keep the current behavior when we switch to npm7
Member
Author
There was a problem hiding this comment.
Yes, it's to make sure it doens't install puppeteer in Gutenberg and in projects that use @wordpress/e2e-test-utils together with @wordpress/scripts that depends on puppeteer-core.
Contributor
Reading this makes me wonder why we have a "puppeteer" dependency then? Should it be "puppeteer-core"? What's the difference? |
Member
Author
Good point. For e2e test utils and e2e tests we can change it to
|
youknowriad
approved these changes
Nov 24, 2021
813feaf to
dda064a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is necessary to bring compatibility with npm 7 and 8. It's based on the work in #33892 (a78030a). npm 7 and above by default installs all peer dependencies and that causes issues because
@wordpres/scriptsusespuppeteer-coreinstead ofpuppeteer. The solution is to makepuppeteeran optional dependency for WordPress packages.As part of the change, this PR also upgrades
puppeteer-coreto the latest version.How has this been tested?
npm run test-e2estill works locally and on CI.Types of changes
Breaking change for some packages and an enhancement for
@wordpress/scripts.Checklist:
*.native.jsfiles for terms that need renaming or removal).