Closed
Conversation
7 tasks
|
Size Change: +4.1 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Baseline before any changes https://github.com/WordPress/gutenberg/runs/4012470808 |
Member
|
Thanks so much for setting this up and reviewing #35817 @gwwar Performance check after commit changes: #35967 (commits) https://github.com/WordPress/gutenberg/runs/4014766222 I think there's a slight drop in performance if I'm reading things right? BeforeAfter |
Contributor
Author
|
So querying for selectedId in the parent affects block focus time. You can test this locally with a post that has ~900 blocks. Trying to focus from one paragraph to another will lag by about a second, as we see here:
More detailed explanation of why is in #35706. But the TL;DR is that by default if a parent updates in React all children re-render regardless of if props change. |
Contributor
Author
|
My other List View performance PR landed in #35230 ✨ I'm going to rebase with trunk to see the perf effects. Ideally changes here shouldn't slow down focus too much after the rebase. |
…t only when a block is selected outside the block list. Using an `useEffect` to loop through parent nodes, and expand them when necessary.
203379c to
b2947ee
Compare
Member
Ouch. Okay I was definitely focussing on the wrong stat 😆 Thanks for the explanation and for doing the heavy lifting on performance checks. |
Contributor
Author
|
Excellent, it looks like with windowing, we shouldn't see the terrible focus slowdown. I'd recommend manually testing to verify, but I think we can query for selectedId in the parent component again. Details |
gwwar
commented
Oct 29, 2021
| setExpandedState( { | ||
| type: 'expand', | ||
| clientId, | ||
| } ); |
Contributor
Author
There was a problem hiding this comment.
Two recommendations here:
- Let's make a new action so we can dispatch a single one instead of many
- It might be worth exploring if we need to keep track of focus or not. (Is there any other state we can query?) I'd timebox this.
Member
There was a problem hiding this comment.
Let's make a new action so we can dispatch a single one instead of many
Good idea. I'll make a start next week. Thanks again, and great work.
Member
|
After pushing the latest changes from #35817 on top of #35230 A big improvement on #35967 (comment) Way to go @gwwar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP alternative #35817
Spinning up a branch with some perf tests enabled, so we can see how different approaches work out.
After we get a baseline run, @ramonjd you're welcome to push to this branch.