Remove locations we do not translate from theme-i18n.json#35881
Merged
Remove locations we do not translate from theme-i18n.json#35881
theme-i18n.json#35881Conversation
aaronrobertshaw
approved these changes
Oct 24, 2021
Contributor
aaronrobertshaw
left a comment
There was a problem hiding this comment.
LGTM as well 👍
✅ All i18n references to font style, font-weight, text-transform, and text decoration removed
✅ Tests are all passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27380 introduced the
theme-i18n.jsonfile (lib/experimental-i18n-theme.jsonat the time) to define which strings from atheme.jsonfile should be picked up for translation.At that point, we were experimenting with presets for a number of new things: font styles, font weights, text transforms, and text decorations. Hence, we had those in the i18n file. Later on, the presets were removed at #27555 but we forgot to also remove them from the i18n file. This PR does that.