fix/2854: getSourcedAttributes was not completely removed#3582
Merged
BoardJames merged 2 commits intomasterfrom Nov 21, 2017
Merged
fix/2854: getSourcedAttributes was not completely removed#3582BoardJames merged 2 commits intomasterfrom
BoardJames merged 2 commits intomasterfrom
Conversation
It was still being used leading to a runtime error in block validation.
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
==========================================
+ Coverage 36.92% 36.92% +<.01%
==========================================
Files 267 267
Lines 6663 6662 -1
Branches 1203 1203
==========================================
Hits 2460 2460
+ Misses 3551 3550 -1
Partials 652 652
Continue to review full report at Codecov.
|
This was referenced Nov 21, 2017
youknowriad
approved these changes
Nov 21, 2017
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
Good catch. Thanks for the fix. I think adding a unit test or end2end test for the HTML mode would be good to avoid future regressions.
Contributor
Yes agreed, we could show the dialog only when returning to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was still being used leading to a runtime error in block validation.
Description
The PR #2854 removed getSourcedAttributes but it was still exported in the
api/index.jsand it was still used in validation of block content after editing as HTML.Note that this may fix issue #3423 as with this fix I can't replicate a block crash only a "This block has been changed externally" dialog. I wonder though why we don't give an option of continuing to edit the HTML (not converting to a HTML block) from that dialog.
How Has This Been Tested?
Manual tests in Firefox and Chrome.
Types of changes
Bug fix.
Checklist: