Skip to content

Child theme.json: update test to better capture that childs can update single parts in isolation#35759

Merged
oandregal merged 1 commit intotrunkfrom
update/test-theme-json-child
Oct 20, 2021
Merged

Child theme.json: update test to better capture that childs can update single parts in isolation#35759
oandregal merged 1 commit intotrunkfrom
update/test-theme-json-child

Conversation

@oandregal
Copy link
Copy Markdown
Member

@oandregal oandregal commented Oct 19, 2021

Follow-up to #35459

Update so we test that single parts can be overridden by the child while untouched parent sections remain the same.

@oandregal oandregal self-assigned this Oct 19, 2021
@oandregal oandregal added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Full Site Editing [Type] Code Quality Issues or PRs that relate to code quality labels Oct 19, 2021
@oandregal oandregal mentioned this pull request Oct 19, 2021
Merged
7 tasks
@oandregal oandregal force-pushed the update/test-theme-json-child branch from e4b8b00 to d24b992 Compare October 19, 2021 12:17
@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Oct 19, 2021

@oandregal, you might want to rebase on the latest trunk. The React Native iOS issue got fixed recently.

@oandregal
Copy link
Copy Markdown
Member Author

oandregal commented Oct 19, 2021

I already did but it seems it's a different error in this case? cc @geriux

Mamaduka
Mamaduka approved these changes Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing for me locally 👍

@geriux
Copy link
Copy Markdown
Member

geriux commented Oct 19, 2021

I already did but it seems it's a different error in this case? cc @geriux

Thanks for the ping, I restarted the job but it failed again, I'll investigate this. 👍

@oandregal oandregal force-pushed the update/test-theme-json-child branch from d24b992 to 724160e Compare October 19, 2021 14:43
@oandregal
Copy link
Copy Markdown
Member Author

oandregal commented Oct 19, 2021

Rebased again to see if that clears the new error out.

@oandregal
Copy link
Copy Markdown
Member Author

oandregal commented Oct 19, 2021

ok, got a new one:

Run sudo xcode-select --switch /Applications/Xcode_12.5.1.app
xcode-select: error: invalid developer directory '/Applications/Xcode_12.5.1.app'
Error: Process completed with exit code 1.

which I also see happening in trunk for a commit after the XCode update https://github.com/WordPress/gutenberg/runs/3940696898

@geriux
Copy link
Copy Markdown
Member

geriux commented Oct 19, 2021

ok, got a new one:

Run sudo xcode-select --switch /Applications/Xcode_12.5.1.app
xcode-select: error: invalid developer directory '/Applications/Xcode_12.5.1.app'
Error: Process completed with exit code 1.

which I also see happening in trunk for a commit after the XCode update https://github.com/WordPress/gutenberg/runs/3940696898

Sorry for that, it looks like the propagation of the Github action changes are taking more than expected so we are hoping to fix it in this PR.

@oandregal oandregal force-pushed the update/test-theme-json-child branch from 724160e to da3f62d Compare October 20, 2021 09:14
@oandregal oandregal merged commit 39be23f into trunk Oct 20, 2021
@oandregal oandregal deleted the update/test-theme-json-child branch October 20, 2021 09:54
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@scruffian scruffian Awaiting requested review from scruffian

@aristath aristath Awaiting requested review from aristath

Assignees

@oandregal oandregal

Labels

[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 11.8

Development

Successfully merging this pull request may close these issues.

3 participants

@oandregal @Mamaduka @geriux