Components: mark CustomSelectControl hint option as experimental#35673
Merged
Components: mark CustomSelectControl hint option as experimental#35673
CustomSelectControl hint option as experimental#35673Conversation
ciampo
commented
Oct 15, 2021
ntsekouras
approved these changes
Oct 15, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Thanks for the follow up Marco! I was wondering if we should make this experimental for now.. We could revisit when the typescript/css-in-js is handled for this component.
What do you think?
Contributor
Author
Usually marking a component as experimental means:
In general, it's good practice to mark all components as experimental when they first get added to the codebase. Doing the second part means renaming all the imports using it — which we can do in Gutenberg, but will break every other codebase using this component (do we have any insights?) |
Contributor
|
Oh no... I meant making(prefixing) the new property experimental, not the component. Sorry for the confusion I caused 😄 |
Contributor
Author
Ah I see! Do you mean something like |
Contributor
Exactly! |
CustomSelectControl changesCustomSelectControl hint option as experimental
Contributor
Author
Hey @ntsekouras , I renamed the prop as suggested, based the changes made in #35395. Could you give it another round of review and make sure that I haven't missed any place when renaming the prop? Thank you! |
|
Size Change: +13 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Oct 15, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Looks great - thank you! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the
hintproperty for theCustomSelectControloptions introduced in #35395 to__experimentalHint, add CHANGELOG entryHow has this been tested?
Typography panel still works
Types of changes
Documentation
Checklist:
*.native.jsfiles for terms that need renaming or removal).