Test that add_theme_supports are loaded for themes without theme.json#34998
Merged
Test that add_theme_supports are loaded for themes without theme.json#34998
add_theme_supports are loaded for themes without theme.json#34998Conversation
Member
|
I think the "React Native E2E Tests (Android)" check got stuck, and there's no way to cancel it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for #34955
How to test
Make sure the test passes in the current
trunk:npm run test-unit-php -- /var/www/html/wp-content/plugins/gutenberg/phpunit/class-wp-theme-json-resolver-test.phpMake sure the test would have failed before #34955:
git checkout -b test/before 4474d01bc88d7ee4edadbf3227852e43e141fb56=> checks out commit priornpm run test-unit-php -- /var/www/html/wp-content/plugins/gutenberg/phpunit/class-wp-theme-json-resolver-test.php=> the expected result is that the test fails.