Allow disabling text and background color via theme.json#34420
Merged
Allow disabling text and background color via theme.json#34420
text and background color via theme.json#34420Conversation
Contributor
|
This looks like it's working as expected. Is it planned to have the option to disable them only on a per block level or only on the global styles? |
Contributor
|
If the theme is setting color options for a block like so: The per-block options are not available if they are set to false under settings, is this expected too? |
Member
Author
Yup, all settings (also styles) are available both at the global and block level. Once something new is added, it works everywhere. |
29c385a to
e65a888
Compare
|
Size Change: +79 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Member
Author
|
@MaggieCabrera would you think you can help approve this if everything works as expected? |
Contributor
yeah, this works as expected! |
MaggieCabrera
approved these changes
Sep 7, 2021
This was referenced Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34414
Description
This also fixes the logic to show the subcomponents of the color panel:
link is enabled when all these conditions are met:
text is enabled when all these conditions are met:
background is enabled when all these conditions are met:
gradients is enabled when all these conditions are met:
As per #34414 we don't need a specific key for gradients.
How to test