FSE: Add basic support for child themes#34354
Merged
Conversation
Contributor
|
Test result:
|
carolinan
approved these changes
Sep 21, 2021
Member
Author
|
Thanks for the review, @carolinan ❤️ |
This was referenced Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #25612.
Fixes #33959.
Fixes #33957.
Adds basic support for child themes in Full Site Editor/Global Styles.
Features covered
theme.jsoninheritance.Props
This is based on previous work by @aristath and @oandregal.
P.S. I'm not sure how we want to handle user-created templates and wasn't able to find any information. I would be happy to iterate on this PR or create a follow-up if anyone can point me in the right direction.
How has this been tested?
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).