Size Change: 0 B

Total Size: 1.04 MB

_{compressed-size-action}

I noticed that in some places we're using import type and in others we're just importing the types directly. Are we following any convention in that regard?

From what I can gather, until recently our preferred option in TypeScript files was to keep the type imports separate from importing runtime code. I believe this technique was used in an attempt to keep the bundle size as small as possible, e.g.

import { myFunction } from './file';
import type { MyType } from './file';

Recently, though, it was discussed and agreed that optimisation isn't really necessary, and so we started switching to merging those import statements into one, e.g.

import { myFunction, MyType } from './file';

Still, it is possible to still encounter an import type statement, in case all of the imported variables are actually TypeScript types, e.g.

import type { MyType, MyOtherType } from './file';

Following the rationale that I just explained, I had a look at the code in this PR and merged import declarations where possible in 6508cd9 (#34330)

All CI tasks seemed to be failing after the last commit — I've tried to rebase on top of trunk hoping it will fix these issues (it may be related to #34377)

Update: the issues seem to persist

Update: all good after last rebase! Going to merge