Upgrade gradle to 7.1.1 agp to 4.2.2#34048
Merged
Conversation
|
Size Change: -300 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
0197209 to
a9896de
Compare
This was referenced Aug 12, 2021
By running: `npm uninstall @wordpress/react-native-editor --save && npm install ./packages/react-native-editor --save`
Bring in the latest changes from react-native-gesture-handler's wp-fork branch
This reverts commit 6073a6b.
This reverts commit bba53be.
This reverts commit 0260fa4.
This reverts commit 1d9bdb3.
Closed
2 tasks
mchowning
approved these changes
Sep 1, 2021
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Looks good! Thanks for this @oguzkocer !
mchowning
requested changes
Sep 1, 2021
Contributor
mchowning
left a comment
There was a problem hiding this comment.
I forgot to test WPAndroid before approving this, and I am seeing the composite build failing there, so I'll remove my approval to make sure we figure out what is going on there.
This is the error message I am seeing.
code/a8c/WordPress-Android c1733ec486 ✔ 29d21h
▶ ./gradlew installWordPressWasabiDebug
Configuration on demand is an incubating feature.
Substituting gutenberg-mobile with the local build
> Configure project :libs:stories-android
Checking whether `configure` binary is present
> Configure project :libs:stories-android:stories
WARNING: DSL element 'android.viewBinding.enabled' is obsolete and has been replaced with 'android.buildFeatures.viewBinding'.
It will be removed in version 5.0 of the Android Gradle plugin.
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/matt/code/a8c/gutenberg-mobile/gutenberg/node_modules/@react-native-community/masked-view/android/build.gradle' line: 2
* What went wrong:
An exception occurred applying plugin request [id: 'com.android.library', version: '4.2.2']
> Failed to apply plugin [id 'com.android.internal.version-check']
> Minimum supported Gradle version is 6.7.1. Current version is 6.1.1. If using the gradle wrapper, try editing the distributionUrl in /Users/matt/code/a8c/gutenberg-mobile/gutenberg/packages/react-native-bridge/android/gradle/wrapper/gradle-wrapper.properties to gradle-6.7.1-all.zip
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 5s
code/a8c/WordPress-Android c1733ec486 ✔ 29d21h ⍉
▶ cat /Users/matt/code/a8c/gutenberg-mobile/gutenberg/packages/react-native-bridge/android/gradle/wrapper/gradle-wrapper.properties
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Contributor
Author
|
As mentioned on Slack, the build failure is due to testing the build on a non Gradle-7 branch. @mchowning is doing another set of tests and will re-approve this PR soon. 🤞 |
mchowning
approved these changes
Sep 1, 2021
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Sorry about my mix-up with the WPAndroid branch. Tested again with the proper branch and, shockingly, things worked so much better! 🤦 Re-approving now.
Member
|
@illusaen pinging you here to see if you can confirm your WordPress.org username so that we can properly credit you in the WordPress 5.9 release? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades react-native Android libraries to Gradle 7 and Android Gradle Plugin 4.2.2. Most of the changes are generated by the Gradle upgrade script:
./gradlew wrapper --gradle-version=7.1.1 --distribution-type=all. It also includes the following changes:Related gb-mobile PR: wordpress-mobile/gutenberg-mobile#3833
How has this been tested?
Manual testing of the react-native demo app and WordPress-Android PR that includes these changes.
Types of changes
Android build file changes for react-native projects & react-native library updates for Android projects.
Checklist:
*.native.jsfiles for terms that need renaming or removal).