Size Change: +18 B (0%)

Total Size: 1.05 MB

_{compressed-size-action}

Thanks for taking a look at this one @aaronrobertshaw! It's testing nicely according to the instructions, and it respects an existing (valid) Button with border radius (and ones with individual border radii):

It looks like one of the test fixtures is failing (for the deprecated radius on the button), and I can see in the editor if I manually copy + paste the content of core__button__border_radius__deprecated.serialized.html into the code view, it doesn't get the radius inline style when I switch back to the visual editor view. The steps I used:

1. Copy + paste the following into the code editor view:

<!-- wp:button {"borderRadius":25} -->
<div class="wp-block-button"><a class="wp-block-button__link" style="border-radius:25px">My button</a></div>
<!-- /wp:button -->

2. Switch to Visual editor view, and we expect the border-radius inline style to be preserved, but instead it gets stripped:

Do we need to update one of the deprecations, too?

Thanks for testing @andrewserong 👍

I'm actually working through the deprecations now.

@andrewserong The problem came down to the deprecation attempting to migrate an old border radius attribute to the style.border.radius attribute without enforcing units were included.

This meant after the deprecation it was trying to save a number to a string attribute and so was ignored. Without the attribute saved, there was nothing to trigger the application of an inline style.

The deprecations have been updated to fix this. Pasting the block code from your comment into the code editor and switching back to the visual editor does result in the block being correctly migrated to the latest version. The block fixtures have been regenerated to accomodate the border radius with unit in the resulting attributes. All the block fixture tests are now passing both locally and on this PR.

Let me know if I've missed anything else.

This PR introduced a regression with blocks which have style.border.radius a number. PR for fix here: #33117.