Description

When showSuggestions prop is passed to <LinkControl> the consumer should expect that the component will not make any HTTP requests for search suggestions.

At first glance this appears to be the case, but if we observe the Network tab we can see that in fact due to an error in the logic within the component, the default search handler attached to the block editor settings is invoked.

This PR fixes things so that if showSuggestions is false then the default "noop" handler is invoked and no HTTP is made.

This issue is what is currently causing flaky e2e tests in the Image block.

How has this been tested?

To manually test:

On Trunk

• Create an Image block.
• Upload an image.
• Open Network tab and clear it out.
• Click Replace on the Image block.
• Then click Edit button that appears.
• You should see a HTTP request is made to the search endpoint in the Network tab.

On this PR

• Create an Image block.
• Upload an image.
• Open Network tab and clear it out.
• Click Replace on the Image block.
• Then click Edit button that appears.
• You should see no HTTP is trigger in the Network tab.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).