[Mobile] - Refactor gallery - Cleanup#32382
Merged
mkevins merged 12 commits intornmobile/refactor/gallery-as-nested-image-blocksfrom Jul 5, 2021
Merged
Conversation
I believe this was inadvertantly removed in some earlier commits, so this commit adds it back.
These flags allow for a slightly more flexible, performant, and terse way of branching by platform. For more details, see: #18058 (comment)
This is necessary for unit tests, because they instantiate the block's edit component directly, and so the default context is not provided.
|
Size Change: +100 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
…rnmobile/refactor/gallery-as-nested-image-blocks-cleanup
This was referenced Jun 3, 2021
antonis
approved these changes
Jun 3, 2021
Member
There was a problem hiding this comment.
Great work @mkevins 👍
Thank you for taking care of this. I tested it running metro and everything works as expected and looks in sync with the web 🎉
Thought in draft I'm approving this now. I can recheck if extra tweaks are needed as discussed.
This will be reverted once the block settings are fetched from the REST API. This is enabled for now for testing purposes.
This brings the same change from this PR: #31027 which may have missed the deprecated hook in the refactor PR, since it hadn't landed yet.
…rnmobile/refactor/gallery-as-nested-image-blocks-cleanup
…rnmobile/refactor/gallery-as-nested-image-blocks-cleanup
4 tasks
7 tasks
This reverts commit 6fbaed9.
Contributor
Author
|
Thank you for reviewing and testing @antonis 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
This PR takes care of some "cleanup" issues, left over from the previous PRs. It adds some props / styles that were inadvertantly removed in prior PRs, and also resumes rendering of the loading spinner for imageSizeOptions on web, which we do not display on mobile.
How has this been tested?
The web gallery (both the old version and the new one) should render and behave exactly the same as they do in the main web gallery PR. In particular, the loading spinner should be present in the controls when the imageSizeOptions are still loading.
Mobile gallery should behave the same as the main mobile PR, and should not result in changes in rendering for other blocks that use the block list, and utilize contentResizeMode 'stretch'.
Note: This also brings in a small addition to the Platform module, discussed here.
Checklist:
*.native.jsfiles for terms that need renaming or removal).