Merged
Conversation
|
Size Change: -822 kB (-44%) 🎉 Total Size: 1.03 MB
ℹ️ View Unchanged
|
ciampo
reviewed
May 27, 2021
ciampo
reviewed
May 27, 2021
ciampo
reviewed
May 27, 2021
Contributor
There was a problem hiding this comment.
Not really sure how to test it as it's mostly styles so there's a snapshot test that encodes the styles that are rendered
- What about adding more snapshot tests when individual props are passed (
error,isFocused,isInline)? - Should there be a Storybook entry for this component too?
ciampo
reviewed
May 27, 2021
ciampo
reviewed
May 27, 2021
ciampo
reviewed
May 27, 2021
ciampo
reviewed
May 27, 2021
51f1140 to
665d323
Compare
2f0fb48 to
ab7d26a
Compare
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
Contributor
|
Also noting that some snapshot tests are failing |
ciampo
reviewed
May 28, 2021
ciampo
approved these changes
May 28, 2021
Contributor
ciampo
left a comment
There was a problem hiding this comment.
Apart from this last comment, this PR looks good — especially given the fact that this component is only internal and marked as experimental.
LGTM 🚀
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
ciampo
reviewed
May 28, 2021
packages/components/src/base-field/test/__snapshots__/index.js.snap
Outdated
Show resolved
Hide resolved
Contributor
Now it LGTM and it also builds successfully :) |
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
BaseFieldprimitive internal (non-exported) component. This component, as the README says, is mostly to be used as a hook by other primitive field components (like TextInput, which will come after this one).How has this been tested?
This has been tested live in the G2 repository. Not really sure how to test it as it's mostly styles so there's a snapshot test that encodes the styles that are rendered 🤷♀️ It's pretty weak though. I think the best way to test this is as part of another component in Storybook but that's not possible until those other components exist!
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).