Merged
Conversation
|
Size Change: +3.19 kB (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
Member
|
Looks nice! The only issue I noticed is that pressing Esc when the menu is open causes the Customizer to navigate back. |
7 tasks
Contributor
Author
Yeah, I'm not sure how to fix that. The popover component does already call |
noisysocks
approved these changes
May 19, 2021
Member
noisysocks
left a comment
There was a problem hiding this comment.
We can fix the Esc thing in a follow-up if you want. This is good 👍
Contributor
Author
|
There's also the same issue with the escape key in the customizer when trying to use:
So I think we need to treat this as a separate issue and disable escape for the entire panel 😬 I've reported it in #31972. |
e61f6a8 to
0e92312
Compare
Member
|
Why was this merged with failing tests? It's not because trunk is failing that that's ok? |
Contributor
|
Awesome 😁 Only notes here are that I think the menu should appear in the top Customizer bar next to the Publish button (even though it's related to the editor, it's getting a little lost where it is currently). Minor note but it would be nice to have the "Preferences" subheading (same style as "View" or "Tools") above the last option.
Related to Esc key functionality: #31730 |
This was referenced May 25, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #30886
Adds the editor 'more menu' to the customize editor.
I haven't added 'Copy all content' yet, as the post editor version copies post content. I think this should be possible (would need to serialize blocks), but I'd like to address it in a follow-up.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).