[RNMobile] Audio block URL Parser unit tests#31920
Merged
jd-alexander merged 60 commits intotrunkfrom May 21, 2021
Merged
Conversation
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
2 tasks
Contributor
Author
|
@fluiddot the failing tests here are flaky as I have re-run them several times. Since these changes are restricted to |
fluiddot
reviewed
May 19, 2021
packages/components/src/mobile/audio-player/audio-url-parser.native.js
Outdated
Show resolved
Hide resolved
| .split( '/' ) | ||
| .pop(); | ||
| const parts = fileName.split( '.' ); | ||
| const extension = parts.length === 2 ? parts.pop().toUpperCase() + ' ' : ''; |
Contributor
There was a problem hiding this comment.
I see that if the file contains an extension. we're adding an extra blank space at the end of the string, what's the reason for this?
Contributor
Author
There was a problem hiding this comment.
Ah, yes, I decided to add a space here because there are times when the extension isn't present but if it is I need to add the space here so within the UI itself the extension doesn't get attached to the audio file Text in the UI. For more context, see this comment #27817 (comment)
Contributor
There was a problem hiding this comment.
Oh ok, I'm wondering if the extra space should be handled then in the component instead since it's specific to how to render it, wdyt? My first impression was that this method was agnostic to the component but maybe since it's located under the same folder makes sense to include it 🤔 .
Contributor
Author
There was a problem hiding this comment.
You are right about the component handling this especially since it's UI-related. I could create another small PR to resolve this since this PR solved the main need which was to add the tests 😄
packages/components/src/mobile/audio-player/test/audio-url-parser.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/audio-player/test/audio-url-parser.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/audio-player/test/audio-url-parser.native.js
Show resolved
Hide resolved
…lock-IV-from-url-unit-tests
Contributor
Author
|
Thanks for such a thorough review @fluiddot I implemented the changes you requested. This PR is ready for another round 🙇🏾 |
This was referenced May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wordpress-mobile/gutenberg-mobile#3524
Description
Refactored the URL parsing logic within the
audio-player. It was moved to another file so it could be testable. Once that was done, unit tests were written for the different URL variations that are supported.How has this been tested?
Insert From URLflow in the audio block's media upload selection works with the refactored URL parsing component.npm run test-unit:nativeand they all passed.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).