Animate menu exit in Navigation component#31874
Closed
Conversation
Plus supporting style changes and addition of a slide-out animation
|
Size Change: +623 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started for the use case of enabling sticky positioned elements within
Navigation. Currently, theoverflow: hiddenstyle ofNavigationprevents sticky positioning so this PR changes it to only hide the overflow during transitions. The exit animation for the menu is actually secondary but it is the bulk of the changes. If for some reason we don't want that, the PR can be scaled back to just the overflow change.Screenshots
In Site Editor
In preferences modal (< medium breakpoint)
nav-animate-exit-prefs-after.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).