Site title: Add option to toggle home link#31540
Merged
Merged
Conversation
13 tasks
|
Size Change: +68 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
carolinan
commented
May 17, 2021
aristath
reviewed
Jun 14, 2021
aristath
approved these changes
Jun 14, 2021
Contributor
Author
|
Is there a good way to remove the |
1fda801 to
6d1271b
Compare
Member
|
There were a lot of conflicts due to recent tweaks in some blocks (see #32817). As a result, I had to rebase the PR and in the process of resolving conflicts I had to refactor a lot of things.
Yes, by returning |
Attempt to resolve merge conflict by reverting the change to the fixture.
Contributor
Author
|
The PR refactor is working well for me, the block works as I expect in the editors and front. There was a merge conflict because the fixtures has moved to test/integration/fixtures/blocks/, so I updated the fixture again to solve it. |
Member
|
As far as I can tell this block is fully dynamic - save content is empty and everything is handled when rendering on the front-end. In that case, you don't have to worry about deprecations. |
Contributor
Author
Thank you, this is confusing because the only documentation I can find for deprecation seems to be for custom blocks. Not for best practices for the plugin/core? |
carolinan
commented
Sep 16, 2021
Member
The most detailed document is here: We should clarify that you need deprecations only when the save implementation outputs something. |
Contributor
I'm not sure this is 100% true 🤔 . For example if we renamed an attribute, wouldn't we need a deprecation and handle the |
ntsekouras
reviewed
Sep 16, 2021
ntsekouras
reviewed
Sep 16, 2021
ntsekouras
reviewed
Sep 16, 2021
ntsekouras
reviewed
Sep 16, 2021
ntsekouras
reviewed
Sep 16, 2021
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your work here @carolinan! Besides some small comments, this looks good!
ntsekouras
approved these changes
Sep 16, 2021
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
This LGTM - thanks!
IMO current copy is not confusing and is something that can be even addressed in a follow up. Besides that, everything else seems good.
|
Hi @carolinan,
Thanks for the ping! I think in this case, Another slightly more active alternative could be, |
Contributor
Author
|
Tests are passing again so I will merge this. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial for #30918
Previously, the site title was always a link. This adds an option to remove the default link.
How has this been tested?
Tested manually by adding a site title block:
Text and link color options
With and without link
With and without opening in a new tab.
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).