Fix unable to publish edited legacy widgets in the customizer#31484
Merged
noisysocks merged 4 commits intotrunkfrom May 5, 2021
Merged
Fix unable to publish edited legacy widgets in the customizer#31484noisysocks merged 4 commits intotrunkfrom
noisysocks merged 4 commits intotrunkfrom
Conversation
|
Size Change: +132 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Member
|
Why does |
Member
|
Here's where it's set. Are we accidentally removing it in the frontend somewhere? |
Member
|
Yes, it looks like |
noisysocks
reviewed
May 5, 2021
talldan
reviewed
May 5, 2021
| block.attributes.instance.encoded, | ||
| instance_hash_key: block.attributes.instance.hash, | ||
| raw_instance: block.attributes.instance.raw, | ||
| ...existingWidget.instance, |
Contributor
There was a problem hiding this comment.
This seems to be throwing an error for new widgets.
I tried adding a SiteOrigin Button, and this line throws because existingWidget is null.
Member
Author
There was a problem hiding this comment.
Oh shoot, forgot about that.
Contributor
There was a problem hiding this comment.
Lets make a note to add some tests for adding/updating/removing legacy widgets 👍
7 tasks
Contributor
|
I think this one might have regressed. At least I can no longer save SiteOrigin legacy widgets in |
Member
Author
I can't reproduce it though 🤔. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #31177.
Add missing
is_widget_customizer_js_valuevalue so that it can be saved and published. Apparently it's required.Currently editing a legacy widget will trigger the whole preview iframe to reload. Not sure why yet.
How has this been tested?
Follow the reproducing steps in #31177.
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).