[Mobile] - Gallery refactor - Migrate old implementation to v1 directory#31260
Merged
mkevins merged 2 commits intornmobile/refactor/gallery-as-nested-image-blocksfrom Apr 29, 2021
Conversation
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
Contributor
Author
|
Thanks for reviewing and testing Antonis! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
tbd
This PR targets the main mobile gallery refactor branch. There is no "main" mobile PR open yet, since it will target the main gallery refactor PR, and this will bring the first changes there (can't open a PR without diff 😃 ). Once this is merged to the main mobile refactor branch, I will draft a PR for that branch targeting the main refactor branch, and all subseqent mobile PRs can target that main mobile branch.
Description
This PR migrates the old implemenation of gallery block to the new v1 directory created for the main gallery refactor. The v1 gallery block will be in use for existing galleries, and for new galleries when the experimental flag is not set.
Testing
Since the flag is not currently set on mobile (i.e.
flag === false), this can be tested via the demo app by interacting with the existing gallery from the demo content, adding an image there, and also created a new gallery in the demo content. The media sources are wired to provide a mock image when selecting from media library, so that can be used to add a single image.The existing and new galleries should behave the same as the previous version.
Checklist:
*.native.jsfiles for terms that need renaming or removal).