File Block: Add support for embedding PDFs#30857
Merged
Conversation
6 tasks
|
Size Change: +1.05 kB (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
Member
Author
|
I think this linting failure is incorrect: it's presumably meant to check for IE11 compatibility, but the JS runs correctly in IE11 when I test the functionality. |
pento
commented
Apr 16, 2021
Member
Author
On further investigation, the linting failure was actually a build failure. It took about a day of diving down infinite rabbit holes to fix it in f57ef25. 🙃 |
gziolo
reviewed
Apr 16, 2021
Member
|
This is a really cool feature! Nice investigation on the newly added capability to build frontend files for blocks. It needs some more work and first-class support in WordPress core as the next step. We need a few more use cases in Gutenberg to ensure the API is useful because there might be interesting use cases for the frontend. |
ntsekouras
reviewed
Apr 16, 2021
ntsekouras
reviewed
Apr 16, 2021
ntsekouras
reviewed
Apr 16, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Cool work here @pento! I've left some comment but nothing major.
Contributor
|
It looks really nice! I am noticing that I can hide the button with a toggle, but can I also hide the text link under the PDF file? Removing/hiding this text link: |
gziolo
reviewed
Apr 19, 2021
Contributor
|
I added a few comments to the issue, and received feedback from a few people. Here is the newest design suggestion. That multiple people would find helpful. #19077 (comment) |
Member
|
I'm marking this PR as needing some follow-up work in WordPress core because of the introduction of the PHP file for the block. We will have to add a note in https://core.trac.wordpress.org/ticket/52991 once it lands. I assume it goes in WordPress 5.8 😄 |
ntsekouras
reviewed
Apr 20, 2021
ntsekouras
reviewed
Apr 20, 2021
ntsekouras
reviewed
Apr 20, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
This is going good @pento ! I retested and I've left just a comment. Thanks!
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
4c49af7 to
7bee495
Compare
ntsekouras
approved these changes
Apr 21, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Great work! 💯 - let's 🚢
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
youknowriad
reviewed
Apr 22, 2021
| "source": "html", | ||
| "selector": "a[download]" | ||
| }, | ||
| "displayPreview": { |
Contributor
There was a problem hiding this comment.
I like this option and I believe we should probably extend it to various file types. Like QuickView for Gutenberg.
Member
There was a problem hiding this comment.
Yes, it looks like previews for different file types are being discussed 👍🏻
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #24233.
See #19077.
This PR adds an option to the File block, when a PDF file is inserted, to show an embedded version of the PDF.
PDFs are a bit of a special case amongst files: they're the only document file type with native embed support in most major browsers (mobile devices excepted).
How has this been tested?
The following scenarios need to be tested:
Screenshots
Screen.Recording.2021-04-15.at.4.10.34.pm.mov
Types of changes
New feature.
Checklist: