Skip to content

Testing: Upgrade React and Enzyme to the latest version#3079

Merged
gziolo merged 1 commit intomasterfrom
update/react-enzyme-upgrade-tests
Oct 20, 2017
Merged

Testing: Upgrade React and Enzyme to the latest version#3079
gziolo merged 1 commit intomasterfrom
update/react-enzyme-upgrade-tests

Conversation

@gziolo
Copy link
Copy Markdown
Member

@gziolo gziolo commented Oct 20, 2017

Description

Another attempt to upgrade React and Enzyme to the latest version. We started exploration in #2813 and this PR should finally make it happen. All tests work as expected.

As part of this diff I also improved the behavior of throwing an error when test executes console.error. I provided new logic which uses spies and expect call to validate if test should fail. New output looks as follow:

● InserterMenu › should disable already used blocks with usedOnce

expect(jest.fn()).not.toHaveBeenCalled()

Expected mock function not to be called but it was called with:
  ["Warning: Expected `onMouseLeave` listener to be a function, instead got a value of `boolean` type.
    in button (created by InserterMenu)
    in div (created by InserterMenu)
    in div (created by InserterMenu)
    in div (created by InserterMenu)
    in div (created by InserterMenu)
    in InserterMenu (created by WrapperComponent)
    in WrapperComponent"], ["Warning: Expected `onMouseEnter` listener to be a function, instead got a value of `boolean` type.
    in button (created by InserterMenu)
    in div (created by InserterMenu)
    in div (created by InserterMenu)
    in div (created by InserterMenu)
    in div (created by InserterMenu)
    in InserterMenu (created by WrapperComponent)
    in WrapperComponent"]
  
  at Object.<anonymous> (test/setup-test-framework.js:23:23)
  at process._tickCallback (internal/process/next_tick.js:109:7)

It's much easier to read and it properly outputs all warnings and errors.

There are still 2 skipped tests. I will take a closer look at them later and decide if we can fix them or they should be removed.

How Has This Been Tested?

Travis should be happy.

Run npm test locally.

To test new behavior around console.error and console.warn simply put such call in one of the tests.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@gziolo gziolo added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 20, 2017
@gziolo gziolo self-assigned this Oct 20, 2017
gziolo
gziolo commented Oct 20, 2017
View reviewed changes
components/navigable-menu/test/index.js Outdated
Copy link
Copy Markdown
Member Author

@gziolo gziolo Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it later. I added this eslint rule to hide warning.

gziolo
gziolo commented Oct 20, 2017
View reviewed changes
editor/inserter/menu.js Outdated
Copy link
Copy Markdown
Member Author

@gziolo gziolo Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes warnings in the InserterMenu component:

Warning: Expected onMouseLeave listener to be a function, instead got a value of boolean type.
Warning: Expected onMouseEnter listener to be a function, instead got a value of boolean type.

@gziolo gziolo force-pushed the update/react-enzyme-upgrade-tests branch from e3e6eb2 to 54e3057 Compare October 20, 2017 10:02
youknowriad
youknowriad reviewed Oct 20, 2017
View reviewed changes
test/setup-test-framework.js Outdated
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@gziolo gziolo mentioned this pull request Oct 20, 2017
Closed
youknowriad
youknowriad reviewed Oct 20, 2017
View reviewed changes
package.json
"mousetrap": "1.6.1",
"prop-types": "15.5.10",
"react": "15.6.1",
"react": "16.0.0",
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

youknowriad
youknowriad approved these changes Oct 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you did it 👍

@gziolo gziolo merged commit d8db04b into master Oct 20, 2017
@gziolo gziolo deleted the update/react-enzyme-upgrade-tests branch October 20, 2017 10:41
@aduth
Copy link
Copy Markdown
Member

aduth commented Oct 20, 2017

Noting that many of our dependencies define a React peer in the 15.x line, so warnings are logged when installing a new version of a package:

npm WARN react-autosize-textarea@0.4.8 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-autosize-textarea@0.4.8 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-slot-fill@1.0.1 requires a peer of react@^15.5.8 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react@^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react-dom@^15.0.0 but none is installed. You must install peer dependencies yourself.

I imagine at least some of these should have updated versions available which define React 16 as a valid peer.

@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Oct 20, 2017

Yes, we can upgrade them after release v1.5. We are using the latest React and React DOM for some time with the bundled code so it seemed like an easier migration path. I can open a follow-up PR on Monday. Thanks for catching this. @youknowriad left a note about this in the preceding PR but I forget to copy it.

@gziolo gziolo mentioned this pull request Oct 23, 2017
Closed
@samouri samouri mentioned this pull request Nov 2, 2017
Merged
@afercia afercia mentioned this pull request Jan 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@aduth aduth Awaiting requested review from aduth

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@gziolo gziolo

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gziolo @aduth @youknowriad