List View: Update list view icon size and spacing#30455
Merged
Conversation
|
Size Change: +9 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
mtias
approved these changes
Apr 2, 2021
Member
mtias
left a comment
There was a problem hiding this comment.
Let's give it a try and see how it feels
aristath
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the icon size and placement in list view feels a bit unbalanced compared to the general spacing of the rows and the block name.
This PR explores how things feel if we reduce the icon size a bit (20px instead of 24px) and increase the spacing a little, giving everything a bit more room the breathe:
Hopefully these changes better prepare us to accomodate future enhancements like expanding / collapsing container blocks, or block actions via ellipsis menu.
cc @mtias